Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation/59288 add stages and gates to the project overview page #17223

Merged
merged 36 commits into from
Dec 18, 2024
Merged

Implementation/59288 add stages and gates to the project overview page #17223

merged 36 commits into from
Dec 18, 2024

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Nov 18, 2024 •
edited
Loading

Ticket

https://community.openproject.org/wp/59288

What are you trying to accomplish?

Display Stages and Gates on the Project Overview page

Screenshots

What approach did you choose and why?

Similar implementation to ProjectCustomFields, as there are a lot of similarities.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz changed the base branch from dev to feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page November 18, 2024 17:18
@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch from f829684 to c485739 Compare November 22, 2024 16:58
Base automatically changed from feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page to dev November 25, 2024 08:31
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch 2 times, most recently from 95ffcb5 to f3dd035 Compare November 26, 2024 20:38
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch 6 times, most recently from a5d6240 to e975e1e Compare December 9, 2024 16:44
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch from e975e1e to 9e0a747 Compare December 11, 2024 10:15
@EinLama EinLama self-requested a review December 17, 2024 11:56
EinLama
EinLama reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! I have added some remarks, most of which are small things. I could not find any major flaws, great job!

config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
app/models/project/stage.rb Show resolved Hide resolved
app/models/project/stage.rb Show resolved Hide resolved
frontend/src/turbo/turbo-global-listeners.ts Outdated Show resolved Hide resolved
modules/overviews/lib/overviews/engine.rb Outdated Show resolved Hide resolved
spec/contracts/project_life_cycle_steps/base_contract_spec.rb Outdated Show resolved Hide resolved
spec/contracts/project_life_cycle_steps/base_contract_spec.rb Outdated Show resolved Hide resolved
spec/models/project/stage_spec.rb Outdated Show resolved Hide resolved
spec/support/pages/projects/show.rb Outdated Show resolved Hide resolved
dombesz added 16 commits December 17, 2024 15:48
@dombesz
wip
5885b03
@dombesz
Display life cycles in the sidebar
96d1f2e
@dombesz
Update variable names
479b9c8
@dombesz
Add Stages and Gates permissions
f0c3df9
@dombesz
Allow instantiation of Project::LifeCycleStepDefinition in order to l…
a115cc5 
…et acts_as_list function correctly.
@dombesz
Rename overview page spec helper methods
13ce90b
@dombesz
Add sidebar specs for displaying life cycles
9b82812
@dombesz
Add view permission specs
b60407e
@dombesz
Add edit permission specs
bfe6a7f
@dombesz
Add Coloured icons, initial rendering of the form fields
002fdf3
@dombesz
Add DatePicker component and dsl for single_date_picker and range_dat…
56445a9 
…e_picker form fields
@dombesz
Display the datepicker input fields on the life cycle edit form
ddf938c
@dombesz
Add ProjecLifeCycleSteps::BaseContract and UpdateContract.
8bb61b7
@dombesz
Make form validations work for nested project life cycle attributes.
bf65858
@dombesz
Add Project::Stage date_range setter and validation.
667d1d5
@dombesz
Remove condition for invalid LifeCycleStep initialization, add valida…
f29a905 
…tion instead.
dombesz and others added 10 commits December 17, 2024 15:56
@dombesz
Add life cycle step increasing dates validation to the ProjectLifeCyc…
6e2f780 
…leStep::BaseContract
@dombesz
Activate associated validations for project life cycle steps only whe…
851f504 
…n validating via the ProjectLifeCycleSteps contracts.
@dombesz
Display duration in days caption for Project::Stage entries.
59bf7cc
@dombesz
Create form preview to interactively calculate duration of selected d…
8306416 
…ates and display error messages on the ProjectLifeCycle dialog.
@dombesz
Allow empty date and date range for Project::LifeCycleStep
1eb9eac
@ulferts @dombesz
exclude OP custom dom elements from being morphed
4bd144d
@dombesz
Enable morphing the Stages and Gates form preview action
8040262
@dombesz
Add validation error border around the datepicker's input.
583a2f3
@dombesz
Add specs for stages and gates edit dialog
5ad7378
@dombesz
Addd more Stage and Gates dialog specs wip.
6ce663b
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch from de130b0 to 7aee3c1 Compare December 17, 2024 13:56
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch from 3168270 to a96fdd1 Compare December 17, 2024 14:54
@dombesz dombesz requested a review from EinLama December 17, 2024 14:56
@dombesz
Copy link
Contributor Author

dombesz commented Dec 17, 2024

Thanks @EinLama for the quick review, I believe I addressed all your comments.

@dombesz dombesz marked this pull request as ready for review December 17, 2024 14:57
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch from 93f7045 to f00f051 Compare December 18, 2024 07:19
@dombesz
Allow retry_block on RSpec::Expectations::ExpectationNotMetError too.
3b7b6c3 
This exception is not included by default, because it does not inherit
from the StandarError, but from the Exception.
@dombesz
Fix rubocop issues
f00f051
EinLama
EinLama approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👏🏻

spec/features/projects/life_cycle/overview_page/dialog/permission_spec.rb Outdated Show resolved Hide resolved
spec/features/projects/life_cycle/overview_page/dialog/update_spec.rb Outdated Show resolved Hide resolved
spec/features/projects/life_cycle/overview_page/sidebar_spec.rb Outdated Show resolved Hide resolved
spec/features/projects/life_cycle/overview_page/sidebar_spec.rb Outdated Show resolved Hide resolved
@dombesz dombesz force-pushed the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch from fbca7cf to f0fce0e Compare December 18, 2024 10:10
@dombesz dombesz merged commit d4fe6d8 into dev Dec 18, 2024
13 checks passed
@dombesz dombesz deleted the implementation/59288-add-stages-and-gates-to-the-project-overview-page branch December 18, 2024 10:29
@dombesz dombesz mentioned this pull request Dec 18, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinLama EinLama EinLama approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dombesz @EinLama @ulferts